X-Git-Url: https://scm.lunaixsky.com/lunaix-os.git/blobdiff_plain/69777bdcab284335651a8002e2896f3862fa423d..32b9a6d76790c73d3d2d36d9081a2581cc65d184:/lunaix-os/kernel/exe/exec.c?ds=inline diff --git a/lunaix-os/kernel/exe/exec.c b/lunaix-os/kernel/exe/exec.c index 6f2962e..0f6e4ec 100644 --- a/lunaix-os/kernel/exe/exec.c +++ b/lunaix-os/kernel/exe/exec.c @@ -120,7 +120,7 @@ exec_load(struct exec_container* container, struct v_file* executable) if (!argv_extra[1]) { // If loading a statically linked file, then heap remapping we can do, // otherwise delayed. - create_heap(vmspace(proc), va_align(container->exe.end)); + create_heap(vmspace(proc), page_aligned(container->exe.end)); } if (container->vms_mnt == VMS_SELF) { @@ -137,6 +137,9 @@ exec_load(struct exec_container* container, struct v_file* executable) memcpy((void*)ustack, (const void*)envp, envp_len); ustack = copy_to_ustack(ustack, (ptr_t*)ustack); + } else { + ustack -= sizeof(ptr_t); + *((ptr_t*)ustack) = 0; } if (argv) { @@ -144,6 +147,9 @@ exec_load(struct exec_container* container, struct v_file* executable) ustack -= argv_len; memcpy((void*)ustack, (const void**)argv, argv_len); + } else { + ustack -= sizeof(ptr_t); + *((ptr_t*)ustack) = 0; } for (size_t i = 0; i < 2 && argv_extra[i]; i++) { @@ -195,6 +201,11 @@ exec_load_byname(struct exec_container* container, const char* filename) goto done; } + if (!check_itype_any(dnode->inode, F_FILE)) { + errno = EISDIR; + goto done; + } + errno = exec_load(container, file); // It shouldn't matter which pid we passed. As the only reader is @@ -252,13 +263,13 @@ __DEFINE_LXSYSCALL3(int, // we will jump to new entry point (_u_start) upon syscall's // return so execve 'will not return' from the perspective of it's invoker - eret_target(current_thread) = container.exe.entry; - eret_stack(current_thread) = container.stack_top; + hart_flow_redirect(current_thread->hstate, + container.exe.entry, container.stack_top); // these become meaningless once execved! current_thread->ustack_top = 0; signal_reset_context(¤t_thread->sigctx); - signal_reset_register(__current->sigreg); + signal_reset_registry(__current->sigreg); done: // set return value