X-Git-Url: https://scm.lunaixsky.com/lunaix-os.git/blobdiff_plain/a13ddcba315eaa75dca84dde30b17a78b2933354..642855f81fd03b9fd6540ac99c665b57b4b38cc8:/lunaix-os/kernel/asm/x86/pfault.c

diff --git a/lunaix-os/kernel/asm/x86/pfault.c b/lunaix-os/kernel/asm/x86/pfault.c
index 6498619..bbaf59f 100644
--- a/lunaix-os/kernel/asm/x86/pfault.c
+++ b/lunaix-os/kernel/asm/x86/pfault.c
@@ -9,6 +9,8 @@
 #include <lunaix/status.h>
 #include <lunaix/syslog.h>
 
+#include <klibc/string.h>
+
 static void
 kprintf(const char* fmt, ...)
 {
@@ -52,7 +54,7 @@ intr_routine_page_fault(const isr_param* param)
     }
 
     volatile x86_pte_t* pte = &PTE_MOUNTED(PD_REFERENCED, ptr >> 12);
-    if ((*pte & PG_PRESENT)) {
+    if (PG_PRESENTED(*pte)) {
         if ((hit_region->attr & COW_MASK) == COW_MASK) {
             // normal page fault, do COW
             cpu_invplg(pte);
@@ -66,28 +68,25 @@ intr_routine_page_fault(const isr_param* param)
         goto segv_term;
     }
 
-    // if (!(*pte)) {
-    //     // Invalid location
-    //     goto segv_term;
-    // }
-
-    uintptr_t loc = *pte & ~0xfff;
-
-    // a writable page, not present, not cached, pte attr is not null
+    // an anonymous page and not present
     //   -> a new page need to be alloc
-    if ((hit_region->attr & REGION_WRITE) && (*pte & 0xfff) && !loc) {
-        cpu_invplg(pte);
-        uintptr_t pa = pmm_alloc_page(__current->pid, 0);
-        if (!pa) {
-            goto oom;
-        }
+    if ((hit_region->attr & REGION_ANON)) {
+        if (!PG_PRESENTED(*pte)) {
+            cpu_invplg(pte);
+            uintptr_t pa = pmm_alloc_page(__current->pid, 0);
+            if (!pa) {
+                goto oom;
+            }
 
-        *pte = *pte | pa | PG_PRESENT;
-        goto resolved;
+            *pte = *pte | pa | PG_PRESENT;
+            goto resolved;
+        }
+        // permission denied on anon page
+        goto segv_term;
     }
 
-    // if mfile is set, then it is a mem map
-    if (hit_region->mfile) {
+    // if mfile is set (Non-anonymous), then it is a mem map
+    if (hit_region->mfile && !PG_PRESENTED(*pte)) {
         struct v_file* file = hit_region->mfile;
         u32_t offset =
           (ptr - hit_region->start) & (PG_SIZE - 1) + hit_region->offset;
@@ -98,17 +97,21 @@ intr_routine_page_fault(const isr_param* param)
         }
 
         cpu_invplg(pte);
-        *pte = *pte | pa | PG_PRESENT;
-        int errno = file->ops->read_page(
-          file->inode, ptr & (PG_SIZE - 1), PG_SIZE, offset);
+        *pte = (*pte & 0xFFF) | pa | PG_PRESENT;
+
+        ptr = ptr & ~(PG_SIZE - 1);
+        memset(ptr, 0, PG_SIZE);
+
+        int errno = file->ops->read_page(file->inode, ptr, PG_SIZE, offset);
         if (errno < 0) {
             kprintf(KERROR "fail to read page (%d)\n", errno);
             goto segv_term;
         }
+
         goto resolved;
     }
 
-    // page not present, bring it from disk or somewhere else
+    // page not present, might be a chance to introduce swap file?
     __print_panic_msg("WIP page fault route", param);
     while (1)
         ;